Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oumi launcher to be able to run on RunPod and Lambda #1470

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

wizeng23
Copy link
Contributor

@wizeng23 wizeng23 commented Feb 22, 2025

Description

Two bug fixes were made to enable running on RunPod and Lambda:

  1. Change the default value of disk_tier from "medium" to None. This is because only AWS, Azure, GCP, and OCI support low/medium/high disk tiers, and the rest only support "best'.
  2. Only set autostop if the cloud supports it. RunPod and Lambda both don't support it. Referencing this code: https://github.com/skypilot-org/skypilot/blob/aa3c387f04fbdd4468751b7d66fcb381bd3449dc/sky/clouds/cloud.py#L592

Tested that launching on RunPod works with these fixes.

Related issues

Fixes #1458
Fixes #1459
Fixes #1461

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

@@ -100,11 +100,12 @@ class JobResources:
Ignored by Polaris.
"""

disk_tier: Optional[str] = "medium"
disk_tier: Optional[str] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if it still works on GCP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed

@wizeng23 wizeng23 changed the title Fix Oumi launcher to be able to run on RunPod Fix Oumi launcher to be able to run on RunPod and Lambda Feb 22, 2025
@wizeng23 wizeng23 merged commit 8445f40 into main Feb 22, 2025
3 checks passed
@wizeng23 wizeng23 deleted the wizeng/1461-runpod branch February 22, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants