Enable pre-release install for uv in pyproject.toml #1466
Conversation
| @@ -31,7 +31,7 @@ envs: | |||
|
|
|||
| setup: | | |||
| set -e | |||
| pip install uv && uv pip install oumi[gpu] | |||
| pip install uv && uv pip install --prerelease=allow oumi[gpu] | |||
There was a problem hiding this comment.
there are a lot of repetitive and verbose changes here. Can this be improved in the future ?
For example, we could make Launcher recognize some special command/macro oumi_pip_install <targets> and
replace oumi_pip_install ... with pip install uv && uv pip install --prerelease=allow ...
so we can avoid such sweeping changes in hundred configs.
This can also make it easier to do changes like this: #1420
There was a problem hiding this comment.
That definitely sounds like a doable feature ask. If we scope it out a bit, we can add this as a public issue.
There was a problem hiding this comment.
This is no longer needed as I took an alternative approach Oussama suggested
|
A PR updating 100 files is unavoidable, as I'll have to do it with Nikolai's suggested change as well. I'm using find-replace to make this change, and am manually review all lines changed before sending it out for review. I understand the concern with this from a reviewing perspective, but IMO creating more convenience wrappers has its own downsides; pip is pretty well known, but if we create oumi_pip, users will now have to search through our code/docs to figure out what it does. If you really want to avoid any massive code changes, I don't see another way besides doing a pip package release in Omegaconf. |
wizeng23
changed the title
--prerelease=allow for all uv pip installs
wizeng23
changed the title
|
Update: Took an alternative approach Oussama suggested to fix this in the pyproject.toml |
Description
Unlike pip, uv disallows prelease packages by default, which we need for
omegaconf==2.4.0dev3foroumi>=0.1.5. This PR fixes that in our pyproject.toml.Related issues
Fixes #1462
Before submitting