-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated oumi infer to support CLI argument for system prompt #1422
Updated oumi infer to support CLI argument for system prompt #1422
Conversation
@Spaarsh some unit tests updates may be needed to take care of the new argument. Please go to the following dir and verify that all CLI unit tests pass:
https://github.com/oumi-ai/oumi/blob/main/CONTRIBUTING.md#running-tests |
Yep it was a mistake from my part. Still figuring out the tests.😅 I have fixed them now, along with the other changes that you suggested. Thanks! |
Hey @Spaarsh - thank you for doing this! We'd love to chat to get your quick feedback - would you mind pinging me in Discord? My handle is @ ciara_oumi |
Description
This change adds an optional argument for
system_prompt
in the CLI for the interactive mode. The two tests have been added that test this change with and without image as an input.The change specifically adds a new argument in
infer
andinfer_interactive
functions. It also adds newMessage
object in theConversation
object for inputs with and without an image input.Further, since this added new code, tests have been added to ensure their functioning. Two tests have been added with and without image input specifically to decouple the testing of system prompt feature independent of the image input for future triages!
Related issues
Fixes #1386
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staff
is required.