Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated oumi infer to support CLI argument for system prompt #1422

Conversation

Spaarsh
Copy link
Contributor

@Spaarsh Spaarsh commented Feb 11, 2025

Description

This change adds an optional argument for system_prompt in the CLI for the interactive mode. The two tests have been added that test this change with and without image as an input.

The change specifically adds a new argument in infer and infer_interactive functions. It also adds new Message object in the Conversation object for inputs with and without an image input.

Further, since this added new code, tests have been added to ensure their functioning. Two tests have been added with and without image input specifically to decouple the testing of system prompt feature independent of the image input for future triages!

Related issues

Fixes #1386

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@nikg4 nikg4 requested a review from taenin February 11, 2025 17:52
@nikg4
Copy link
Collaborator

nikg4 commented Feb 11, 2025

@Spaarsh some unit tests updates may be needed to take care of the new argument. Please go to the following dir and verify that all CLI unit tests pass:

cd tests/unit/cli/
pytest -s -vv

https://github.com/oumi-ai/oumi/blob/main/CONTRIBUTING.md#running-tests

@Spaarsh
Copy link
Contributor Author

Spaarsh commented Feb 11, 2025

@Spaarsh some unit tests updates may be needed to take care of the new argument. Please go to the following dir and verify that all CLI unit tests pass:

cd tests/unit/cli/
pytest -s -vv

https://github.com/oumi-ai/oumi/blob/main/CONTRIBUTING.md#running-tests

Yep it was a mistake from my part. Still figuring out the tests.😅

I have fixed them now, along with the other changes that you suggested. Thanks!

@nikg4 nikg4 merged commit da3a0c1 into oumi-ai:main Feb 12, 2025
2 checks passed
@ciaralema
Copy link
Collaborator

Hey @Spaarsh - thank you for doing this! We'd love to chat to get your quick feedback - would you mind pinging me in Discord? My handle is @ ciara_oumi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update oumi infer to support CLI argument for system prompt
3 participants