Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak --mem-fraction-static param in sample SGLang configs #1328

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

nikg4
Copy link
Collaborator

@nikg4 nikg4 commented Jan 31, 2025

Description

-- The previous value --mem-fraction-static=0.99 was selected to run Llama 3.2 Vision on GPU with 24GB (barely fits), and generally such a high limit is unsafe/not-recommended to use. 0.9 is more reasonable.

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@nikg4 nikg4 requested a review from wizeng23 January 31, 2025 22:52
@nikg4 nikg4 marked this pull request as ready for review January 31, 2025 22:52
@nikg4 nikg4 requested review from taenin, optas and oelachqar January 31, 2025 22:53
@nikg4 nikg4 merged commit 24296d6 into main Jan 31, 2025
1 check passed
@nikg4 nikg4 deleted the xrdauakr/sglang-param branch January 31, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants