Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tiny] upgrade torch version #1295

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[tiny] upgrade torch version #1295

merged 4 commits into from
Jan 29, 2025

Conversation

oelachqar
Copy link
Contributor

Description

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@nikg4
Copy link
Collaborator

nikg4 commented Jan 29, 2025

What torch version is picked up by [ci_gpu]?

@oelachqar
Copy link
Contributor Author

What torch version is picked up by [ci_gpu]?

It's the same version, why?

@nikg4
Copy link
Collaborator

nikg4 commented Jan 29, 2025

What torch version is picked up by [ci_gpu]?

It's the same version, why?

previously I did see some cases where a different version is selected.

@nikg4
Copy link
Collaborator

nikg4 commented Jan 29, 2025 •
edited
Loading

Is there a specific/strong reason for the version increment?

This change can potentially have adverse destabilizing effects . Can we hold it as a fast-follow?

taenin
taenin reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@taenin taenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to holding on this change for our next PyPi release

@oelachqar oelachqar merged commit 33afa09 into main Jan 29, 2025
2 checks passed
@oelachqar oelachqar deleted the oelachqar/update_torch branch January 29, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taenin taenin taenin left review comments

@wizeng23 wizeng23 wizeng23 approved these changes

@nikg4 nikg4 Awaiting requested review from nikg4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oelachqar @nikg4 @taenin @wizeng23