Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more e2e evaluation tests #1237

Merged
merged 8 commits into from
Jan 26, 2025
Merged

Add more e2e evaluation tests #1237

merged 8 commits into from
Jan 26, 2025

Conversation

nikg4
Copy link
Collaborator

@nikg4 nikg4 commented Jan 25, 2025 •
edited
Loading

Description

-- Add more e2e evaluation test cases
-- Minor updates to launcher script and test names
-- Update checkpoints validations for LoRA adapters

Related issues

Towards OPE-926, OPE-909

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@linear Linear
Copy link

linear bot commented Jan 25, 2025

OPE-926

@nikg4 nikg4 marked this pull request as ready for review January 25, 2025 21:37
@linear Linear
Copy link

linear bot commented Jan 25, 2025

OPE-909

@nikg4 nikg4 requested a review from kaisopos January 26, 2025 01:56
@nikg4 nikg4 merged commit 18d3341 into main Jan 26, 2025
2 checks passed
@nikg4 nikg4 deleted the xrdaukar/it-v4 branch January 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelachqar oelachqar oelachqar approved these changes

@kaisopos kaisopos kaisopos approved these changes

@taenin taenin Awaiting requested review from taenin

@wizeng23 wizeng23 Awaiting requested review from wizeng23

@optas optas Awaiting requested review from optas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikg4 @oelachqar @kaisopos