Scaffolding and the first testcase for e2e evaluation tests #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taenin
reviewed
Jan 24, 2025
Comment on lines
+76
to
+77
| # Overriding nested fields using OmegaConf's dot-list syntax is complicated, | ||
| # or impossible. Let's just create a modified config copy instead. |
There was a problem hiding this comment.
We should probably log a bug for this. If we're struggling with it, users definitely will too.
There was a problem hiding this comment.
taenin
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Scaffolding and the first testcase for e2e evaluation tests
-- Refactor a couple of common helper utils used in e2e tests
-- Improve logging for OmegaConf merge errors
Related issues
Towards OPE-926, OPE-934
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.