Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete oumi[optional] install target #1224

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Delete oumi[optional] install target #1224

merged 4 commits into from
Jan 24, 2025

Conversation

wizeng23
Copy link
Contributor

Description

  1. Users likely won't want both, as Llama CPP is mainly for Mac and vLLM is mainly for CUDA.
  2. The llama-cpp-python installation is currently broken
  3. These two are usually only installed together for our CI tests

Related issues

Towards OPE-533
Fixes OPE-925

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

@linear Linear
Copy link

linear bot commented Jan 24, 2025

OPE-925

OPE-533

@wizeng23 wizeng23 merged commit 59318ea into main Jan 24, 2025
3 checks passed
@wizeng23 wizeng23 deleted the wizeng/optional branch January 24, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelachqar oelachqar oelachqar approved these changes

@kaisopos kaisopos kaisopos approved these changes

@taenin taenin Awaiting requested review from taenin

@nikg4 nikg4 Awaiting requested review from nikg4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizeng23 @oelachqar @kaisopos