Update tests to make them runnable on GCP #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
changed the title
oelachqar
approved these changes
Jan 22, 2025
| from pathlib import Path | ||
|
|
||
|
|
||
| def get_configs_dir() -> Path: |
There was a problem hiding this comment.
I think these should be under conftest with the other generic text fixtures
There was a problem hiding this comment.
Noted. Note that these are regular functions, not fixtures: Unlike test fixtures they weren't visible in tests by default if defined in conftest (I haven't fully figured out how to use conftest yet). May revisit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Add GCP Launcher script for running tests.
-- Minimal changes to making tests pass on GCP multi-GPU machine.
-- New utils to get locations of
testdata,notebooks(get_oumi_root_directory().parent...leads tominiconda3location foroumipackage~/miniconda3/lib/python3.10/site-packages/oumivs/home/gcpuser/sky_workdir/)-- Tested on GCP
A100:4,A100:1, locally, and on Github-- Minor improvements.
Related issues
Towards OPE-698, OPE-909
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.