Define single_gpu test marker
#1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
changed the title
@requires_gpu test marker@requires_gpu test decorator
oelachqar
reviewed
Jan 21, 2025
nikg4
changed the title
@requires_gpu test decoratorsingle_gpu test marker
…test-max-gpu-count
oelachqar
reviewed
Jan 22, 2025
| @@ -235,4 +235,5 @@ addopts = ["--import-mode=prepend"] | |||
| markers = [ | |||
| "e2e: Slow e2e integration tests", | |||
| "e2e_eternal: Extremely slow e2e integration tests (for manual/selective runs)", | |||
| "single_gpu: The test uses max 1 GPU (can be potentially skipped on multi-GPU machine to conserve GPU resources)", | |||
There was a problem hiding this comment.
Given most tests run with 1 gpu, maybe we should mark multi-gpu instead? e.g. multigpu_160gb
There was a problem hiding this comment.
Ack. Will iterate on these.
oelachqar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Define
single_gputest marker to allow skipping such tests on multi-GPU machines if needed.Related issues
Towards OPE-698, OPE-909
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.