Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in most notebooks #1047

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix issues in most notebooks #1047

merged 3 commits into from
Jan 10, 2025

Conversation

wizeng23
Copy link
Contributor

Description

  • Update configs to they output saved models to the appropriate directory
  • Switch to using SmolLM in more places
  • Switched to mmlu_college_computer_science as the eval benchmark. While it's not as useful of a metric, mmlu/hellaswag take nearly 10 minutes to run which may be a bit slow for users

Related issues

Towards OPE-713

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

@linear Linear
Copy link

linear bot commented Jan 10, 2025

OPE-713

taenin
taenin reviewed Jan 10, 2025
View reviewed changes
notebooks/Oumi - Running Jobs Remotely.ipynb
"To install Oumi, you can find detailed instructions [here](https://github.com/oumi-ai/oumi/blob/main/README.md), but it should be as simple as:\n",
"\n",
"```bash\n",
"pip install -e \".[gpu]\" # if you have an nvidia or AMD GPU\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider having them use the main pypi target instead of the local "." target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm making them consistent to each other for now, but we should definitely have a follow-up linear issue to update all our pip installation instructions. This applies to docs too, where we currently use both . and oumi

taenin
taenin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@taenin taenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good to me. Do make sure all of your cell execution count changes are intended

@wizeng23 wizeng23 merged commit 3154c08 into main Jan 10, 2025
2 checks passed
@wizeng23 wizeng23 deleted the wizeng/notebook branch January 10, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelachqar oelachqar oelachqar approved these changes

@taenin taenin taenin approved these changes

@nikg4 nikg4 nikg4 approved these changes

@kaisopos kaisopos Awaiting requested review from kaisopos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wizeng23 @oelachqar @taenin @nikg4