Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tiny] Cleanup judge engine builder & fix circular dep #1035

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[tiny] Cleanup judge engine builder & fix circular dep #1035

merged 1 commit into from
Jan 10, 2025

Conversation

oelachqar
Copy link
Contributor

@oelachqar oelachqar commented Jan 10, 2025 •
edited
Loading

Description

  • Cleanup judge engine builder & fix circular dependency

Towards OPE-836

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@linear Linear
Copy link

linear bot commented Jan 10, 2025

OPE-836

@oelachqar oelachqar changed the title [tiny] Cleanup judge engine builder & fix circular dip [tiny] Cleanup judge engine builder & fix circular dep Jan 10, 2025
@oelachqar oelachqar merged commit a8fcc86 into main Jan 10, 2025
1 check passed
@oelachqar oelachqar deleted the oelachqar/fix_circular_dep branch January 10, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeng23 wizeng23 wizeng23 approved these changes

@taenin taenin Awaiting requested review from taenin

@nikg4 nikg4 Awaiting requested review from nikg4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oelachqar @wizeng23