Update the registry to load registered core values upon use. #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oelachqar
approved these changes
Jan 9, 2025
nikg4
reviewed
Jan 9, 2025
| @@ -5,7 +5,6 @@ | |||
| import datasets | |||
| from trl.trainer import ConstantLengthDataset | |||
|
|
|||
| import oumi.datasets # should always be imported here to register datasets | |||
There was a problem hiding this comment.
this may also help with https://linear.app/oumi/issue/OPE-836 (!)
nikg4
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the registry is empty if it's the only module that's imported. Registering our default datasets, clouds, models, and judge configs requires importing the appropriate packages after importing the registry.
This change adds a decorator to initialize these values once upon using a method in the registry.
This also fixes breaking tests, such as https://github.com/oumi-ai/oumi/blame/main/tests/integration/cli/test_judge_e2e.py
Related issues
Towards OPE-836
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.