Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDL comment test does not run due to passing in a nonpath string into cat #654

Closed
stxue1 opened this issue May 29, 2024 · 0 comments · Fixed by #660
Closed

WDL comment test does not run due to passing in a nonpath string into cat #654

stxue1 opened this issue May 29, 2024 · 0 comments · Fixed by #660

Comments

@stxue1
Copy link
Collaborator

stxue1 commented May 29, 2024

wdl/SPEC.md

Line 422 in fc24d91

cat ~{number * 2}

This should probably be echo instead of cat

@jdidion jdidion closed this as completed Jun 26, 2024
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request in

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants