Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict editing of QuestionnaireResopnse to when saving draft is enabled #3723

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Mar 4, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3722

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.9%. Comparing base (1542bb7) to head (e79f3d5).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3723   +/-   ##
=======================================
  Coverage     37.9%   37.9%           
+ Complexity    1157    1153    -4     
=======================================
  Files          287     287           
  Lines        15504   15448   -56     
  Branches      2730    2719   -11     
=======================================
- Hits          5884    5865   -19     
+ Misses        8776    8744   -32     
+ Partials       844     839    -5     
Flag Coverage Δ
engine 60.7% <ø> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 66.7% <ø> (-0.1%) ⬇️

... and 1 file with indirect coverage changes

@Rkareko Rkareko requested a review from FikriMilano March 4, 2025 10:25
@Rkareko Rkareko marked this pull request as ready for review March 4, 2025 12:25
@Rkareko Rkareko requested review from LZRS and f-odhiambo March 4, 2025 15:42
@Rkareko
Copy link
Contributor Author

Rkareko commented Mar 5, 2025

Some CQL tests are failing which are not related to changes made on this PR. Fix for the failing tests will be tracked on issue #3725

@Rkareko Rkareko merged commit 3cc0a90 into main Mar 5, 2025
4 of 5 checks passed
@Rkareko Rkareko deleted the 3722-edit-qr-only-in-save-draft-mode branch March 5, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only edit QuestionnaireResponses when using Save Draft functionality
2 participants