Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QR Code Scanning UI #3438

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Update QR Code Scanning UI #3438

merged 8 commits into from
Aug 16, 2024

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Aug 13, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3437

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Aug 13, 2024
@LZRS LZRS force-pushed the qr_code_scan_ui branch from aa5002d to ecb1dbf Compare August 13, 2024 21:21
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 60.49383% with 32 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (490c294) to head (24cae48).
Report is 13 commits behind head on main.

Files Patch % Lines
.../ui/sdc/qrCode/scan/QRCodeScannerDialogFragment.kt 61.1% 14 Missing and 14 partials ⚠️
...t/ui/sdc/qrCode/CameraPermissionsDialogFragment.kt 33.3% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3438     +/-   ##
=========================================
+ Coverage     27.0%   27.2%   +0.1%     
- Complexity     720     742     +22     
=========================================
  Files          269     276      +7     
  Lines        13517   13811    +294     
  Branches      2433    2504     +71     
=========================================
+ Hits          3662    3764    +102     
- Misses        9373    9540    +167     
- Partials       482     507     +25     
Flag Coverage Δ
engine 64.6% <ø> (+<0.1%) ⬆️
geowidget 11.4% <ø> (ø)
quest 5.5% <60.4%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...artregister/fhircore/quest/util/QrCodeScanUtils.kt 100.0% <100.0%> (ø)
...t/ui/sdc/qrCode/CameraPermissionsDialogFragment.kt 57.1% <33.3%> (ø)
.../ui/sdc/qrCode/scan/QRCodeScannerDialogFragment.kt 61.1% <61.1%> (ø)

... and 1 file with indirect coverage changes

@LZRS LZRS force-pushed the qr_code_scan_ui branch from ecb1dbf to 9459350 Compare August 13, 2024 21:59
@LZRS
Copy link
Contributor Author

LZRS commented Aug 14, 2024

@LZRS LZRS marked this pull request as ready for review August 14, 2024 09:27
@LZRS LZRS requested review from ellykits, allan-on and Rkareko August 14, 2024 09:27
@LZRS LZRS added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 70ceb20 Aug 16, 2024
5 checks passed
@LZRS LZRS deleted the qr_code_scan_ui branch August 16, 2024 13:40
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Update qr code scan to use bottomsheetdialog ui

* Fix failing QrCodeCameraPermissionsDialogFragment tests

* Update tests for QR code scanning

* Update documentation on support for qr_code-widget extension

---------

Co-authored-by: Allan Onchuru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update QR Code Scanning UI
3 participants