Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for P2P Sync #3192

Merged
merged 15 commits into from
May 15, 2024
Merged

Docs for P2P Sync #3192

merged 15 commits into from
May 15, 2024

Conversation

SebaMutuku
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.5%. Comparing base (ac82739) to head (b5442db).
Report is 48 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3192     +/-   ##
=========================================
- Coverage     29.6%   29.5%   -0.2%     
- Complexity     658     693     +35     
=========================================
  Files          239     252     +13     
  Lines        11204   11886    +682     
  Branches      1948    2071    +123     
=========================================
+ Hits          3323    3507    +184     
- Misses        7447    7920    +473     
- Partials       434     459     +25     
Flag Coverage Δ
engine 64.9% <ø> (-1.3%) ⬇️
geowidget 47.2% <ø> (ø)
quest 5.5% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

id | uniquieId of your p2p_sync block | yes | |
visible | Boolean to show whether this is to be shown | yes | `apps` |
display | Title text that should be shown on the device | yes | |
menuIconConfig | The icon to show. This can be configured through ICON configuration. See widgets | No | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add the link to the ICON config directly here please?

actions | Action to be performed when once clicks on the display above. See actions parameters under questionnaire | yes | |

:::info
A WORKFLOW can be launched anywhere on the app through an action. Either by a text link, actionable button, or image icon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the WORKFLOW you are referring to here?

@ellykits ellykits merged commit 2dc4f28 into main May 15, 2024
3 checks passed
@ellykits ellykits deleted the add_docs_for_p2p_sync branch May 15, 2024 06:08
ellykits added a commit that referenced this pull request Jul 18, 2024
* Add Internationalization documentation 📝 (#3221)

* Add Internationalization documentation 📝
* Disable autobackup - not recommended
* Pin Mac OS runner version to previous stable version | Fix build 💚

* Remove init block blocking thrown errors (#3231)

* Interpolate image visible property (#3234)

* Configs Versioning (#3189)

* Configs versioning setup

* init implementation guide version in settings screen

* remove unused tag

* add string resource

* fetch composition referenced in IG

* add implementationguide to test

* Add ImplementationGuide resource

* update tests

* Update implementation_guide_config.json

* Refactor flow

* Rename implementationGuideUrl to implementationGuideId

- Code cleanup

* Format implementation_guide_config.json

* Run spotlessApply

* Remove implementationGuideId entry from app config

- Add name field to IG config
- Update variable name

* Refactor implementation from config registry

* refactor to use IG by version

* Run spotlessApply

* Refactors and bug fixes

* Update sample ImplementationGuide URL and version

* Update fetchRemoteIG app URL

* Remove flavour from versionName when fetching IG

* Save IG after fetch

* save ImplementationGuide to database

* introduce fetchConfiguration IG test skeletons

* Update IG URL to FQDN

* find and sort IG by context-quantity

* fix failing tests

* update IG tests

* use implmentaionGuide extension guide

* use version code for context-quantity

* empty commit to trigger checks

* run spotlessApply

* remove unnecessary implementationGuide details from userSettingsScreen

* spotlessApply

* initiate Implementation Guide documentation

* Update strings.xml

Co-authored-by: Peter Lubell-Doughtie <[email protected]>

---------

Co-authored-by: Simon Njoroge <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Co-authored-by: Peter Lubell-Doughtie <[email protected]>

* Fix questionnaire prepopulation using initialExpression (#3240)

* Implement searchable multiselect widget (#3123)

* Implement multiselectview

Start implementation on multi-select view. Includes the checkbox and listeners

Signed-off-by: Elly Kitoto <[email protected]>

* Change preview data

Signed-off-by: Elly Kitoto <[email protected]>

* Use TristateCheckbox on MultiSelect view

Signed-off-by: Elly Kitoto <[email protected]>

* Implement functionality for generating map required in multiselectview

Signed-off-by: Elly Kitoto <[email protected]>

* Implement bottomsheet for multi select widget

Signed-off-by: Elly Kitoto <[email protected]>

* Fix multi-select checkbox select color

Signed-off-by: Elly Kitoto <[email protected]>

* Implement functionality for node selection

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor multi select implementation

Use Tree data structure as required. Search Tree instead of
searching the map. Render the UI from the Tree.

Signed-off-by: Elly Kitoto <[email protected]>

* Improve UX on multi selector widget search

Hide keyboard when search action is triggered. Reset data when search
text is empty.

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor MultiSelect UI to use Compose Scaffold

Signed-off-by: Elly Kitoto <[email protected]>

* Use ProtoDataStore to store SyncLocations

Also refactored how root nodes are identified. Use configuration instead
of defaulting to a node without a parent node as the root node.

Signed-off-by: Elly Kitoto <[email protected]>

* Use selected locations from multi-select widget to sync resources

Add comma separated values for _syncLocations query parameter for all requests for the
configured sync Resources.

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor ApplicationConfiguration.syncStrategies to syncStrategy

Signed-off-by: Elly Kitoto <[email protected]>

* Fix child node checked state issue

* Show progress dialog

* Add no results view

* Refactor initial sync logic + disable sync progresss dialog

* Disable progress dialog on initial sync

* Fix spotless formatting errors

* Add Practitioner to SyncStrategy

* Fix failing tests

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Co-authored-by: Hamza Ahmed Khan <[email protected]>
Co-authored-by: Hamza Ahmed Khan <[email protected]>

* Change questionnaire button styling (#3244)

* [Build Variant] ECD App (#3222)

* Initial Commit

* Add custom view holder for choice input type password in Questionnaire

* Add ECD Hack config

* Update constants to one place

* Remove ECDHack app variant

---------

Co-authored-by: mapratama <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: SebaMutuku <[email protected]>

* Bump express from 4.18.2 to 4.19.2 (#3182)

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Implement feature to compute distance between two locations via Rules (#3107)

* Add location service with Preference feature.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Update tests WIP

Signed-off-by: Lentumunai-Mark <[email protected]>

* Use subject's Related Entity Location meta tag on related resources (#3097)

* Use subject's Related Entity Location meta tag on related resources
---------

Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: pld <[email protected]>

* eir demo flavor (#3102)

* update admin-dashboard-feature docs (#3084)

Co-authored-by: Benjamin Mwalimu <[email protected]>

* Add location service with Preference feature.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Resolve conflicts

Signed-off-by: Lentumunai-Mark <[email protected]>

* Run spotless apply.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Run spotless Apply.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add deny permission for UI automator

Signed-off-by: Lentumunai-Mark <[email protected]>

* Grant permission on tests where required.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Remove unused functions.

Signed-off-by: Lentumunai-Mark <[email protected]>

* rename function to be more descriptive.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Adress PR feedback provided.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Format files changed by running spotlessApply

Signed-off-by: Lentumunai-Mark <[email protected]>

* Update application config to remove outdated variables

* Use data store on Location service

Signed-off-by: Lentumunai-Mark <[email protected]>

* Change grant permission rule.

Signed-off-by: Lentumunai-Mark <[email protected]>

* fix spotless check

Signed-off-by: Lentumunai-Mark <[email protected]>

* Change how we're accessing permission rule.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Run spotless check.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Try resolve failing test.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add permission granted rule.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add @ignore to the failing tests

Signed-off-by: Lentumunai-Mark <[email protected]>

* Test commit, trying out new CI fixes.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Fix spotless check

Signed-off-by: Lentumunai-Mark <[email protected]>

* Update AppMainActivityTest.kt

* Fix spotless check failing.

Signed-off-by: Lentumunai-Mark <[email protected]>

---------

Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: Elly Kitoto <[email protected]>
Co-authored-by: pld <[email protected]>
Co-authored-by: Roy <[email protected]>
Co-authored-by: Owais <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>

* Enhance Insight Screen UX (#3195)

* swap app and assignment info

* update tests

* edit insights screen

* edit insights screen

* edit insights screen

* edit insights screen

* remove null username

* cater for empty parameters

* Enhance UI

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: Martin Ndegwa <[email protected]>
Co-authored-by: Elly Kitoto <[email protected]>

* added new property in service-card configs to control the status-icon-size on register screen (#3219)

Co-authored-by: owais-vd <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>

* Fix remove household (#3262)

Co-authored-by: Aleem Azhar <[email protected]>

* Fix disable edit fields not working (#3247)

* Remove unanswered linkId from questionnaireResponse

so that default initial values for the linkId get picked from Questionnaire

* Apply patch changes from #3218

* Migrate Knowledge and Workflow SDK library versions (#3266)

* Update Code release process documentation

* Migrate Knowledge and Workflow SDK library versions

* Docs for P2P Sync (#3192)

* Docs for P2P Sync

* Update image correctly

* Update formatting

* cleanup text and fix image location

* Add links to references

* Update p2p documentation

---------

Co-authored-by: pld <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Co-authored-by: Francis Odhiambo <[email protected]>
Co-authored-by: Elly Kitoto <[email protected]>

* Fix sort and filter issues (#3254)

* Activate sorting for related resources

Signed-off-by: Elly Kitoto <[email protected]>

* Remove material3 dependencies

Signed-off-by: Elly Kitoto <[email protected]>

* Use all the provided register filter criteria

Previously only the filter criteria that were updated by content
from the Questionnaire fields were used.

Signed-off-by: Elly Kitoto <[email protected]>

* Set questionnaire submit button text via configuration

Signed-off-by: Elly Kitoto <[email protected]>

* Implement clear all action on register filter questionnaire

Signed-off-by: Elly Kitoto <[email protected]>

* Add more assertion on register filter data queries test

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>

* Fix filtering by integer

* Activate sorting for related resources

Signed-off-by: Elly Kitoto <[email protected]>

* Remove material3 dependencies

Signed-off-by: Elly Kitoto <[email protected]>

* Use all the provided register filter criteria

Previously only the filter criteria that were updated by content
from the Questionnaire fields were used.

Signed-off-by: Elly Kitoto <[email protected]>

* Set questionnaire submit button text via configuration

Signed-off-by: Elly Kitoto <[email protected]>

* Implement clear all action on register filter questionnaire

Signed-off-by: Elly Kitoto <[email protected]>

* Add more assertion on register filter data queries test

Signed-off-by: Elly Kitoto <[email protected]>

* Fix filter by number

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>

* Add Encounter Participant to TransformSupportServices

* added structure-defnition resource-type in ConfigurationRegistry

* 🐛 [WIP] Adding the value set resolver

---------

Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Co-authored-by: L≡ZRS <[email protected]>
Co-authored-by: Hamza Ahmed Khan <[email protected]>
Co-authored-by: Hilary Baraka Egesa <[email protected]>
Co-authored-by: Simon Njoroge <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Co-authored-by: Peter Lubell-Doughtie <[email protected]>
Co-authored-by: Elly Kitoto <[email protected]>
Co-authored-by: Hamza Ahmed Khan <[email protected]>
Co-authored-by: Francis Odhiambo <[email protected]>
Co-authored-by: mapratama <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: SebaMutuku <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lentumunai Mark <[email protected]>
Co-authored-by: Roy <[email protected]>
Co-authored-by: Owais <[email protected]>
Co-authored-by: Rachel Murabula <[email protected]>
Co-authored-by: Syed Owais Ali <[email protected]>
Co-authored-by: owais-vd <[email protected]>
Co-authored-by: Aleem Azhar <[email protected]>
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Docs for P2P Sync

* Update image correctly

* Update formatting

* cleanup text and fix image location

* Add links to references

* Update p2p documentation

---------

Co-authored-by: pld <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Co-authored-by: Francis Odhiambo <[email protected]>
Co-authored-by: Elly Kitoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants