-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HotFix: Fix scrolling of data on registers #3157
Conversation
@Raynafs do you mind sharing a video as proof? |
Screencast.from.19-03-2024.05.23.48.ALASIRI.webm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
=========================================
+ Coverage 29.6% 29.7% +0.1%
Complexity 658 658
=========================================
Files 239 239
Lines 11204 11191 -13
Branches 1948 1940 -8
=========================================
+ Hits 3323 3331 +8
+ Misses 7447 7425 -22
- Partials 434 435 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Great! Can we write tests covering this? |
@pld I have added the test. Though the intergrated tests have been disabled hence why codecov shows 0%. |
* Fix registerScreen bug * Add test to check that the cardlist is scrollable --------- Co-authored-by: Sebastian <[email protected]>
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file