Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: Fix scrolling of data on registers #3157

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

Raynafs
Copy link
Contributor

@Raynafs Raynafs commented Mar 19, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Raynafs Raynafs requested a review from SebaMutuku March 19, 2024 13:59
@SebaMutuku
Copy link
Contributor

@Raynafs do you mind sharing a video as proof?

@Raynafs
Copy link
Contributor Author

Raynafs commented Mar 19, 2024

Screencast.from.19-03-2024.05.23.48.ALASIRI.webm

@SebaMutuku

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 29.7%. Comparing base (ac82739) to head (eaab31a).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3157     +/-   ##
=========================================
+ Coverage     29.6%   29.7%   +0.1%     
  Complexity     658     658             
=========================================
  Files          239     239             
  Lines        11204   11191     -13     
  Branches      1948    1940      -8     
=========================================
+ Hits          3323    3331      +8     
+ Misses        7447    7425     -22     
- Partials       434     435      +1     
Flag Coverage Δ
engine 66.4% <ø> (+0.2%) ⬆️
geowidget 47.2% <ø> (ø)
quest 5.4% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

SebaMutuku
SebaMutuku previously approved these changes Mar 19, 2024
Copy link
Contributor

@SebaMutuku SebaMutuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@SebaMutuku SebaMutuku changed the title fix registerScreen bug HotFix: Fix scrolling of data on registers Mar 19, 2024
@pld
Copy link
Member

pld commented Mar 19, 2024

Tested and works

Great! Can we write tests covering this?

@Raynafs
Copy link
Contributor Author

Raynafs commented Mar 20, 2024

@pld I have added the test. Though the intergrated tests have been disabled hence why codecov shows 0%.

@ndegwamartin ndegwamartin merged commit f52e8f7 into main Mar 20, 2024
4 of 5 checks passed
@ndegwamartin ndegwamartin deleted the fix-bug-in-register-screen branch March 20, 2024 12:05
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Fix registerScreen bug
* Add test to check that the cardlist is scrollable

---------

Co-authored-by: Sebastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants