Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the infinite loader if the QuestionnaireResponse is invalid #2843

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

qaziabubakar-vd
Copy link
Collaborator

@qaziabubakar-vd qaziabubakar-vd commented Oct 30, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/ona-health/sid-dto-fhir-resources/issues/224

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2843 (cab9eaf) into main (ad3a737) will increase coverage by 5.7%.
Report is 96 commits behind head on main.
The diff coverage is 67.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2843     +/-   ##
=========================================
+ Coverage     64.5%   70.2%   +5.7%     
+ Complexity    1075     611    -464     
=========================================
  Files          218     114    -104     
  Lines         9635    4194   -5441     
  Branches      1897     803   -1094     
=========================================
- Hits          6218    2947   -3271     
+ Misses        2234     802   -1432     
+ Partials      1183     445    -738     
Flag Coverage Δ
engine 70.5% <68.1%> (-2.2%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️
quest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ngine/configuration/view/CompoundTextProperties.kt 100.0% <ø> (ø)
...r/fhircore/engine/domain/model/RoundingStrategy.kt 100.0% <100.0%> (ø)
...gister/fhircore/engine/rulesengine/RulesFactory.kt 71.8% <100.0%> (+0.6%) ⬆️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (ø)
...r/fhircore/engine/task/FhirResourceExpireWorker.kt 100.0% <100.0%> (ø)
...fhircore/engine/task/FhirTaskStatusUpdateWorker.kt 100.0% <100.0%> (ø)
...re/engine/ui/components/register/RegisterFooter.kt 67.3% <100.0%> (+2.1%) ⬆️
...g/smartregister/fhircore/engine/ui/theme/Colors.kt 100.0% <100.0%> (ø)
...rcore/engine/util/extension/FhirEngineExtension.kt 80.0% <100.0%> (+2.8%) ⬆️
...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt 86.6% <100.0%> (+0.3%) ⬆️
... and 27 more

... and 114 files with indirect coverage changes

@ellykits
Copy link
Collaborator

Looks good. Fix failing test.

@qaziabubakar-vd qaziabubakar-vd merged commit eb90db5 into main Nov 2, 2023
@qaziabubakar-vd qaziabubakar-vd deleted the issue-224-sid-app branch November 2, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants