Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to questionnaire activity #2784

Merged
merged 12 commits into from
Oct 13, 2023
Merged

Conversation

hilpitome
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hilpitome hilpitome requested a review from ellykits September 28, 2023 06:39
@pld pld requested review from pld and removed request for ellykits September 28, 2023 06:44
pld
pld previously approved these changes Sep 28, 2023
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2784 (051da97) into main (ad3a737) will increase coverage by 3.0%.
Report is 82 commits behind head on main.
The diff coverage is 63.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2784     +/-   ##
=========================================
+ Coverage     64.5%   67.5%   +3.0%     
- Complexity    1075    1112     +37     
=========================================
  Files          218     223      +5     
  Lines         9635   10229    +594     
  Branches      1897    1877     -20     
=========================================
+ Hits          6218    6914    +696     
+ Misses        2234    2123    -111     
- Partials      1183    1192      +9     
Flag Coverage Δ
engine 71.7% <68.4%> (-1.0%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️
quest 64.7% <59.2%> (+5.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rtregister/fhircore/engine/cql/LibraryEvaluator.kt 92.2% <100.0%> (+0.6%) ⬆️
...r/fhircore/engine/domain/model/RoundingStrategy.kt 100.0% <100.0%> (ø)
...gister/fhircore/engine/rulesengine/RulesFactory.kt 71.8% <100.0%> (+0.6%) ⬆️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (ø)
...ister/fhircore/engine/task/FhirTaskExpireWorker.kt 100.0% <100.0%> (ø)
...fhircore/engine/task/FhirTaskStatusUpdateWorker.kt 100.0% <100.0%> (ø)
...rcore/engine/util/extension/FhirEngineExtension.kt 80.0% <100.0%> (+2.8%) ⬆️
...hircore/engine/util/extension/ResourceExtension.kt 69.6% <100.0%> (-0.3%) ⬇️
...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt 86.6% <100.0%> (+0.3%) ⬆️
...ircore/quest/data/register/RegisterPagingSource.kt 73.6% <100.0%> (+2.2%) ⬆️
... and 64 more

... and 33 files with indirect coverage changes

@hilpitome hilpitome requested review from ellykits and pld October 12, 2023 09:57
@hilpitome hilpitome merged commit c76000c into main Oct 13, 2023
@hilpitome hilpitome deleted the add-test-to-questionnaire-activity branch October 13, 2023 09:09
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* add test to questionnaire activity

* add test to questionnaire activity

Co-authored-by: LZRS <[email protected]>

* run spotlessApply.

Co-authored-by: LZRS <[email protected]>

* manually remove spaces.

Co-authored-by: LZRS <[email protected]>

* remove runtest wrapper

---------

Co-authored-by: LZRS <[email protected]>
Co-authored-by: Peter Lubell-Doughtie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants