Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for composable MemberProfileBottomSheetView #2758

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

hilpitome
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2758 (6501982) into main (ad3a737) will increase coverage by 1.3%.
Report is 54 commits behind head on main.
The diff coverage is 61.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2758     +/-   ##
=========================================
+ Coverage     64.5%   65.8%   +1.3%     
+ Complexity    1075    1051     -24     
=========================================
  Files          218     220      +2     
  Lines         9635    9830    +195     
  Branches      1897    1803     -94     
=========================================
+ Hits          6218    6477    +259     
- Misses        2234    2244     +10     
+ Partials      1183    1109     -74     
Flag Coverage Δ
engine 72.1% <66.8%> (-0.6%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ata/remote/fhir/resource/FhirResourceDataSource.kt 93.3% <0.0%> (+0.4%) ⬆️
...hircore/engine/domain/model/FhirResourceConfigs.kt 43.2% <0.0%> (-1.3%) ⬇️
...ster/fhircore/engine/p2p/dao/BaseP2PTransferDao.kt 70.9% <0.0%> (-19.5%) ⬇️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 91.6% <0.0%> (-8.4%) ⬇️
...ter/fhircore/engine/sync/OpenSrpDownloadManager.kt 42.8% <0.0%> (ø)
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 30.4% <0.0%> (-2.9%) ⬇️
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...ter/fhircore/quest/data/QuestXFhirQueryResolver.kt 0.0% <0.0%> (-100.0%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 0.0% <0.0%> (-48.4%) ⬇️
... and 53 more

... and 32 files with indirect coverage changes

ellykits
ellykits previously approved these changes Sep 15, 2023
hilpitome and others added 2 commits September 15, 2023 11:51
Co-authored-by: Lazarus <[email protected]>
Co-authored-by: hilpitome <[email protected]>"

Signed-off-by: Lentumunai-Mark <[email protected]>
@pld pld merged commit 143b1c8 into main Sep 18, 2023
@pld pld deleted the cht-2023-09-14 branch September 18, 2023 15:11
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add tests for composable MemberProfileBottomSheetView

Co-authored-by:  hilpitome <[email protected]>

* Refactor bottomsheetViewtest.
Co-authored-by: Lazarus <[email protected]>
Co-authored-by: hilpitome <[email protected]>"

Signed-off-by: Lentumunai-Mark <[email protected]>

---------

Signed-off-by: Lentumunai-Mark <[email protected]>
Co-authored-by: L≡ZRS <[email protected]>
Co-authored-by: hilpitome <[email protected]>
Co-authored-by: Lentumunai-Mark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants