Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image widget documentation #2497

Merged
merged 2 commits into from
Jun 27, 2023
Merged

add image widget documentation #2497

merged 2 commits into from
Jun 27, 2023

Conversation

hilpitome
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hilpitome hilpitome requested a review from f-odhiambo June 27, 2023 07:30
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #2497 (fdcb0b4) into main (2ea8fa1) will decrease coverage by 0.1%.
The diff coverage is 65.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2497     +/-   ##
=========================================
- Coverage     64.8%   64.8%   -0.1%     
- Complexity    1050    1060     +10     
=========================================
  Files          209     210      +1     
  Lines         9156    9149      -7     
  Branches      1805    1796      -9     
=========================================
- Hits          5942    5937      -5     
- Misses        2059    2060      +1     
+ Partials      1155    1152      -3     
Flag Coverage Δ
engine 72.8% <65.2%> (-0.3%) ⬇️
geowidget 63.2% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ine/configuration/view/ViewPropertiesSerializer.kt 25.0% <0.0%> (-1.4%) ⬇️
...e/engine/ui/bottomsheet/RegisterBottomSheetView.kt 51.2% <0.0%> (-2.5%) ⬇️
...g/smartregister/fhircore/quest/QuestApplication.kt 44.2% <ø> (+0.8%) ⬆️
...artregister/fhircore/quest/ui/main/AppMainEvent.kt 100.0% <ø> (ø)
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 75.0% <ø> (+0.5%) ⬆️
...ter/fhircore/quest/ui/main/components/AppDrawer.kt 70.2% <ø> (+1.4%) ⬆️
...egister/fhircore/quest/ui/profile/ProfileScreen.kt 49.7% <ø> (+0.2%) ⬆️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 56.8% <ø> (+0.9%) ⬆️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 76.3% <ø> (-1.3%) ⬇️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 30.4% <ø> (+1.0%) ⬆️
... and 25 more

... and 1 file with indirect coverage changes

@pld pld merged commit 53b35a9 into main Jun 27, 2023
@pld pld deleted the document-image-widget branch June 27, 2023 12:35
@roywanyaga roywanyaga added the New Feature PR label for new feature/enhancement on release notes label Aug 10, 2023
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* add image widget documentation

* Update widget-config.mdx

---------

Co-authored-by: Peter Lubell-Doughtie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature PR label for new feature/enhancement on release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants