OG-630 - Boosted gasPrice is sometimes lower after boosing than before #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
force-pushed
the
relayer-boost-fix
branch
from
149b3ed to
0de23e6
Compare
apply our minimum value also to boosted transactions. (NOTE: we still don't know how a small (e.g. 1 wei) value got into the DB of old transactions, but in general, current GasPrice is good minimum not only for new transactions but also for boosted transactions.
drortirosh
force-pushed
the
relayer-boost-fix
branch
from
0de23e6 to
3064f91
Compare
shahafn
approved these changes
Nov 15, 2021
shahafn
added a commit
that referenced
this pull request
Dec 13, 2021
#708) apply our minimum value also to boosted transactions. (NOTE: we still don't know how a small (e.g. 1 wei) value got into the DB of old transactions, but in general, current GasPrice is good minimum not only for new transactions but also for boosted transactions. * Adding tests
shahafn
added a commit
that referenced
this pull request
Dec 20, 2021
* Fixing selection default mechanism * OG-636 obscure revert message in validateRelayCall (#706) unable to decode error from relayCall revert (e.g. "paymaster balance too low") * OG-630 - Boosted gasPrice is sometimes lower after boosing than before (#708) apply our minimum value also to boosted transactions. (NOTE: we still don't know how a small (e.g. 1 wei) value got into the DB of old transactions, but in general, current GasPrice is good minimum not only for new transactions but also for boosted transactions. * Adding tests Co-authored-by: Dror Tirosh <[email protected]> Co-authored-by: Alex Forshtat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply our minimum value also to boosted transactions.
(NOTE: we still don't know how a small (e.g. 1 wei) value got into the
DB of old transactions, but in general, current GasPrice is good minimum
not only for new transactions but also for boosted transactions.