OG-515 support pagination for all log queries #637
Conversation
1. Add 'maxPageSize' as constructor parameter for ContractInteractor. Not optional as pagination will be needed for all packages (cli, relay & provider) and tests should be adjusted. 2. Move implementation of pagination support to the Contracts Interactor 3. Fix bug in 'splitRange' that would cause it to lose the last block in requested range, create test for it. 4. Remove unused config 'relayLookupWindowParts' but keep dynamic adjust 5. Add 'coldRestartLogsFromBlock' config to avoid scanning from block 1 Also, fix or ignore some minor TypeScript errors in tests as they were previously excluded from compilation.
forshtat
force-pushed
the
limited_logging_support
branch
from
595cf09 to
69a068e
Compare
| return pagesForBlockWindow | ||
| } | ||
|
|
||
| splitRange (fromBlock: BlockNumber, toBlock: BlockNumber, parts: number): Array<{ fromBlock: BlockNumber, toBlock: BlockNumber }> { |
There was a problem hiding this comment.
This function is too similar to getPagesForBlockWindow, and they have the same calculation inside - which is generally a bad thing. In this case, you actually have a bug that if you provide to any getPastEvents function in interactor toBlock = 'latest', it will throw in line 441, even though getPagesForBlockWindow supports it.
There was a problem hiding this comment.
They do have a same calculation but do the opposite things. splitRange has existed before this change and is responsible for translation of 1 range into X smaller ranges. getPagesForBlockWindow determines X. The common code is boilerplate and can be extracted, generally speaking.
* Fixing limited_logging_support branch * Adding activityBlockRate, fixing registration
| @@ -4,7 +4,7 @@ | |||
| "license": "MIT", | |||
| "main": "dist/GsnTestEnvironment.js", | |||
| "files": [ | |||
| "dist/*", | |||
| "dist/src/*", | |||
There was a problem hiding this comment.
huh?
currently, I nothing in dist/src. all 3 types in this package are in /distt
There was a problem hiding this comment.
I have changed the tsconfig.js to include test files, so unless we want ./dist/test in @opengsn/dev, they should be excluded.
There was a problem hiding this comment.
Also, you made 17 writing errors in this sentence! 😂
| @@ -202,6 +202,7 @@ contract('Paymaster Commitment', function ([_, relayOwner, relayManager, relayWo | |||
|
|
|||
| }, sharedRelayRequestData, chainId, forwarderInstance) | |||
| const gasAndDataLimits = await paymasterContract.getGasAndDataLimits() | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
can you use ts-error with explicit message, so we know what is wrong?
There was a problem hiding this comment.
Not always. Some errors do not manifest while running via ts-node and then it failed for me. Might be fixed already, but needs separate verification.
| @@ -24,15 +24,15 @@ services: | |||
| restart: always | |||
| ports: [ '8080:80' ] #bypass https-portal | |||
| # add line for each relay | |||
| command: | |||
| - gsn1 | |||
| command: | |||
No description provided.