Update eye_base.php #8101
Open
Update eye_base.php #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait please, there are other changes that are in this PR but my lack of git knowledge is the problem. Please hold... |
|
OK, I see that the earlier changes were submitted for a PR. Sorry they should have all been in one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IOPDATE timestamps were not being properly handled. The IOPPOSTTIME wasn't being stored either. The displayed versions of time have to be converted to a mysql "time" format 00:00:00 for the DB. This is easier than changing the DB field type and safer, perhaps even the correct fix. Look forward to the review.