reactive.isolate() fixes infinite loop
#311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
changed the title
reactive.isolate() fixes infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we just see a change in the reactive values, we should not redraw the inputs.
(Turn on "ignore whitespace in diff" in github to make the review easier).
I went down a little dead end before remembering this method: It's not clear to me that the increment/decrement buttons are actually a good thing, or that the plots should rerender on every keypress. A separate PR addresses that, but doesn't really fix the bug:
text_input+update_on="blur"reduces unnecessary re-renders #310