Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support median #299

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Support median #299

wants to merge 18 commits into from

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Mar 20, 2025

  • Fix Support medians #323
  • Ignore a non-deterministic matplotlib warning
  • Factor out shared analysis shiny inputs: Besides shortening the code, this reduces the chances of IDs getting out of sync.
  • Up the minimum contributions to 2 temporarily to avoid calculating median: contributions=1 + public_info="lengths" causes unable to infer bounds opendp#2331 -- but the real fix is With delta, margins can be dropped #262
  • Add an option for downloading the python source that is used to generate the notebook. Probably only useful for developers, but not obtrusive.
  • Add another column, self_assessment, to the demo CSV: With more analysis options, it is useful to have more data to analyze.
  • In the generated notebooks, names were colliding. Change the binned data from column_config to column_bin_config.
  • Add markdown section headers to generated notebook to improve readability.

For the moment, it just makes 100 candidates between the lower and upper bounds. This is probably be changed, but I'm not sure what the right design is. Opened an issue, but shouldn't try to resolve that in this PR.

Reporting details are still TODO:

@mccalluc
Copy link
Contributor Author

mccalluc commented Mar 21, 2025

Filed an issue upstream:

Will wait for feedback on that before proceeding here.

@mccalluc mccalluc marked this pull request as ready for review March 29, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Support medians
1 participant