Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of grpc internal api #13510

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 13, 2025

Resolves #13504
This only works for the javaagent instrumentation. When our grpc library instrumentation is used with armeria then information derived from the :authority header (server.address, server.port) is lost.

@laurit laurit requested a review from a team as a code owner March 13, 2025 13:37
@trask trask added this to the v2.14.0 milestone Mar 13, 2025
@trask trask merged commit 7dc73f0 into open-telemetry:main Mar 13, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc.v1_6.TracingServerInterceptor must not use io.grpc.InternalMetadata
2 participants