-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement genai events for bedrock (non-streaming) #13473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
...rc/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeAccess.java
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeAttributesGetter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeImpl.java
Show resolved
Hide resolved
@@ -67,6 +68,10 @@ private static boolean recordIndividualHttpError() { | |||
"otel.instrumentation.aws-sdk.experimental-record-individual-http-error", false); | |||
} | |||
|
|||
private static boolean genaiCaptureMessageContent() { | |||
return getBoolean("otel.instrumentation.genai.capture-message-content", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add this to the readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added it
I'll add streaming events after both this PR and #13410
/cc @codefromthecrypt