Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement genai events for bedrock (non-streaming) #13473

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Mar 7, 2025

I'll add streaming events after both this PR and #13410

/cc @codefromthecrypt

@anuraaga anuraaga requested a review from a team as a code owner March 7, 2025 11:31
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@@ -67,6 +68,10 @@ private static boolean recordIndividualHttpError() {
"otel.instrumentation.aws-sdk.experimental-record-individual-http-error", false);
}

private static boolean genaiCaptureMessageContent() {
return getBoolean("otel.instrumentation.genai.capture-message-content", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this to the readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added it

@trask trask merged commit d45ebfa into open-telemetry:main Mar 10, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants