-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tapir path matching within pekko instrumentation #13386
Add tapir path matching within pekko instrumentation #13386
Conversation
masonedmison
commented
Feb 24, 2025
•
edited
Loading
edited
- Ensure tilde$1 onExit is run in correct order #13360 must be merged first.
2ee8ccc
to
5491d18
Compare
5491d18
to
18f27dc
Compare
@laurit Would you be able to look at this for me 🙂? |
@masonedmison I think with your current approach pekko-http instrumentation will fail to apply when tapir is not available during runtime. You can try this our by changing the tapir dependency to be compileOnly + testCompileOnly. This is because we have tooling that detects which classes are used by the instrumentation and when those classes are missing instrumentation is not applied. It is probably easiest to treat it as completely separate instrumentation. An alternative would be to have it in the same module as pekko but have it in a different |
@laurit Very good catch--sorry I missed this! I'm pursuing the second approach first (just pushed up a commit): I've created a separate
Looking at the doc string for |
24ee821
to
aa4c1b8
Compare
instrumentation/pekko/pekko-http-1.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
...trumentation/pekkohttp/v1_0/server/route/TapirPekkoHttpServerRouteInstrumentationModule.java
Outdated
Show resolved
Hide resolved
aa4c1b8
to
e122ec4
Compare
@laurit sorry to be a bother, but would you have a chance to look at my changes following your last comment? |
@laurit Thank you very much for helping me get this together. I really appreciate it. I see that this is slated to go out in the |
second half of next week, see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/RELEASING.md#release-cadence |