-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenTelemetry instrumentation for ActiveJ HTTP server #13335
Conversation
|
f90bed1
to
dfa49e2
Compare
…nabling distributed tracing and context propagation for ActiveJ-based HTTP servers
dfa49e2
to
b52c49d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will want integration tests for any new instrumentation
...emetry/javaagent/instrumentation/activejhttp/ActiveJHttpServerConnectionInstrumentation.java
Outdated
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/activejhttp/ActiveJHttpServerConnectionInstrumentation.java
Outdated
Show resolved
Hide resolved
…nAsWordInName) at class level
7396363
to
b241b45
Compare
@jaydeluca I have added test cases and resolved most of the workflow job failures. But, still there are couple of them are failing and not able to understand the cause after checking the raw logs as well. Could you please help me to understand what causing them to failure so that I can fix them. Thank you! |
@laurit Thanks for the link. So, all the agents should support minimum java 8? |
Thanks for the help! @laurit . Build looks good now. Please review |
...emetry/javaagent/instrumentation/activejhttp/ActivejHttpServerConnectionInstrumentation.java
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/activejhttp/ActivejHttpServerConnectionInstrumentation.java
Outdated
Show resolved
Hide resolved
.../javaagent/instrumentation/activejhttp/ActivejHttpServerConnectionInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHelper.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
...t/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejRoutingServletTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…13372) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]>
…h2-http to v1.33.0 (open-telemetry#13387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…h2-http to v1.33.1 (open-telemetry#13395) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
open-telemetry#13397) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Overview
This PR introduces OpenTelemetry instrumentation for the ActiveJ framework, enabling distributed tracing and context propagation for ActiveJ-based HTTP servers. The changes allow developers to monitor and debug ActiveJ applications in distributed systems by capturing trace context from incoming requests and propagating it through responses.
Key Features
traceparent
header.Changes Included
Instrumentation:
ActiveJHttpServerConnectionInstrumentation
: Instruments theserve
method of ActiveJ servlets to capture and propagate trace context.Testing:
Documentation:
Testing
traceparent
header.Benefits
Related Issues
Closes #13202
Acknowledgments
This implementation was inspired by and adapted from the ActiveJ framework codebase. Special thanks to the ActiveJ community for their excellent work and contributions.