-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jdk.httpserver
instrumentation
#13243
Conversation
|
...a/io/opentelemetry/javaagent/instrumentation/httpserver/JdkServerContextInstrumentation.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/javaagent/instrumentation/httpserver/JdkHttpServerInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/javaagent/instrumentation/httpserver/JdkHttpServerInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/httpserver/JdkServerContextInstrumentation.java
Outdated
Show resolved
Hide resolved
...agent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpserver/JdkSingletons.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/javaagent/instrumentation/httpserver/ResponseCustomizingFilter.java
Outdated
Show resolved
Hide resolved
...er/library/src/main/java/io/opentelemetry/instrumentation/httpserver/JdkServerTelemetry.java
Outdated
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/httpserver/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/httpserver/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/httpserver/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/httpserver/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
|
||
@Override | ||
public String getHttpRoute(HttpExchange exchange) { | ||
return exchange.getHttpContext().getPath(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Route must have a low cardinality. Often it is not possible to get route for a low level server framework. Just return null
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow, exchange.getHttpContext().getPath()
gives you the configured path for the route, not what is currently matched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is, if you do
HttpServer server = HttpServer.create(new InetSocketAddress(port), 0);
server.createContext("/path/" ctx ->{});
and send a request to /path/something
, you'll get /path/
from exchange.getHttpContext().getPath()
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/httpserver/internal/JdkHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
Outdated
Show resolved
Hide resolved
@laurit perchance do you know why it's failing now? |
I haven't followed the discussions above, but looks like its:
you could opt-out of the http pipelining test initially at least, look for |
what's the best way to search these error logs, I'm having trouble locating the actual tests that are failing. |
9c36483
to
10b3679
Compare
So I add a Readme and the pipeline fails? |
we have been doing some compliance work in the repo recently which introduced a couple of new required PR checks, and so just need to rebase to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SentryMan @laurit! one suggestion on the package name
Adds instrumentation for the
jdk.httpserver
module.will resolve #13216 when I get the agent working