-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert OpenTelemetry phase before Setup #13239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed an issue, where the Span status isn't set in case of an error |
Fixed |
e5l
approved these changes
Feb 7, 2025
LGTM |
This commit installs a route-scoped plugin that may mask exceptions from OpenTelemetry, if the latter is configured at the wrong phase
I expanded one of the current test cases so that it'd fail on master, but pass with this PR. I don't like that I needed to install the plugin where I did, but I didn't find a better place for it. If you have any suggestions, pls fire away |
laurit
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13237
The root cause of the issue is that the tracing context is applied too late in the pipeline (
Monitoring
phase). I moved it before theSetup
phase so that the tracing setup becomes the first thing that happens during processing.The
Monitoring
phase is still important because it allows us to check if the call finished without errors. If this got moved to theSetup
phase along with the tracing setup, it'd mean that exception handling inCallFailed
hooks would mask the error, and it wouldn't be reported.