Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact query string values for http client spans #13114

Merged
merged 22 commits into from
Feb 27, 2025

Conversation

jeanbisutti
Copy link
Member

@jeanbisutti jeanbisutti commented Jan 27, 2025

@jeanbisutti jeanbisutti requested a review from a team as a code owner January 27, 2025 14:02
@jeanbisutti jeanbisutti marked this pull request as draft January 27, 2025 14:02
@jeanbisutti jeanbisutti force-pushed the redact-query-string-values branch 2 times, most recently from aba2207 to 608bc78 Compare January 27, 2025 14:43
arguments("https://github.com#[email protected]", "https://github.com#[email protected]"),
arguments("user1:[email protected]", "user1:[email protected]"),
arguments("https://github.com@", "https://github.com@"),
arguments(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was (probably inadvertly) removed in #9925.

The test is added again with new test cases.

@jeanbisutti jeanbisutti marked this pull request as ready for review January 27, 2025 15:18
@jeanbisutti jeanbisutti force-pushed the redact-query-string-values branch 2 times, most recently from d8d8dc3 to c95b161 Compare January 27, 2025 16:57
@trask trask added this to the v2.13.0 milestone Feb 10, 2025
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Feb 11, 2025
@jeanbisutti jeanbisutti requested a review from laurit February 11, 2025 15:55
@laurit
Copy link
Contributor

laurit commented Feb 13, 2025

semantic conventions define the same redactions for url.query in http server spans

@trask
Copy link
Member

trask commented Feb 13, 2025

I think it's ok to scope this PR to http client spans since that's the primary issue in Java at least (update the title, the config option is already scoped to http clients)

@jeanbisutti
Copy link
Member Author

semantic conventions define the same redactions for url.query in http server spans

I have created #13292

@jeanbisutti jeanbisutti changed the title Redact query string values Redact query string values for http client spans Feb 13, 2025
@jeanbisutti jeanbisutti force-pushed the redact-query-string-values branch from f9a1d63 to 4911e83 Compare February 17, 2025 13:40
@jeanbisutti jeanbisutti force-pushed the redact-query-string-values branch from edcdb3a to 5164fe5 Compare February 18, 2025 16:44
@jeanbisutti
Copy link
Member Author

@trask Does it seem good for you?

…tion/api/semconv/http/HttpClientAttributesExtractor.java
@trask trask enabled auto-merge (squash) February 27, 2025 15:34
@trask trask merged commit 5b287e3 into open-telemetry:main Feb 27, 2025
61 checks passed
chlos pushed a commit to chlos/opentelemetry-java-instrumentation that referenced this pull request Mar 3, 2025
Co-authored-by: Steve Rao <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants