Redact query string values for http client spans #13114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
force-pushed
the
redact-query-string-values
branch
2 times, most recently
from
aba2207 to
608bc78
Compare
jeanbisutti
commented
Jan 27, 2025
| arguments("https://github.com#[email protected]", "https://github.com#[email protected]"), | ||
| arguments("user1:[email protected]", "user1:[email protected]"), | ||
| arguments("https://github.com@", "https://github.com@"), | ||
| arguments( |
There was a problem hiding this comment.
This test was (probably inadvertly) removed in #9925.
The test is added again with new test cases.
jeanbisutti
force-pushed
the
redact-query-string-values
branch
2 times, most recently
from
d8d8dc3 to
c95b161
Compare
jaydeluca
reviewed
Jan 27, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
steverao
reviewed
Jan 28, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 28, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
steverao
reviewed
Jan 29, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 29, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
steverao
approved these changes
Jan 30, 2025
laurit
reviewed
Jan 30, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 30, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 30, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 30, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
github-actions
bot
added
the
test native
laurit
reviewed
Feb 12, 2025
...c/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/CommonConfig.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 12, 2025
...try/instrumentation/api/incubator/builder/internal/DefaultHttpClientInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 12, 2025
...mentation/api/incubator/semconv/http/HttpClientExperimentalHttpParamsRedactionExtractor.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 13, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
|
semantic conventions define the same redactions for |
|
I think it's ok to scope this PR to http client spans since that's the primary issue in Java at least (update the title, the config option is already scoped to http clients) |
I have created #13292 |
jeanbisutti
changed the title
… other experimental options
…tion/api/semconv/http/HttpClientAttributesExtractor.java Co-authored-by: Lauri Tulmin <[email protected]>
jeanbisutti
force-pushed
the
redact-query-string-values
branch
from
f9a1d63 to
4911e83
Compare
jeanbisutti
force-pushed
the
redact-query-string-values
branch
from
edcdb3a to
5164fe5
Compare
laurit
reviewed
Feb 20, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 20, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 20, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
laurit
approved these changes
Feb 20, 2025
|
@trask Does it seem good for you? |
laurit
reviewed
Feb 25, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 27, 2025
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
…tion/api/semconv/http/HttpClientAttributesExtractor.java
chlos
pushed a commit
to chlos/opentelemetry-java-instrumentation
that referenced
this pull request
Mar 3, 2025
Co-authored-by: Steve Rao <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md