-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact query string values for http client spans #13114
Redact query string values for http client spans #13114
Conversation
aba2207
to
608bc78
Compare
arguments("https://github.com#[email protected]", "https://github.com#[email protected]"), | ||
arguments("user1:[email protected]", "user1:[email protected]"), | ||
arguments("https://github.com@", "https://github.com@"), | ||
arguments( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was (probably inadvertly) removed in #9925.
The test is added again with new test cases.
d8d8dc3
to
c95b161
Compare
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/CommonConfig.java
Outdated
Show resolved
Hide resolved
...try/instrumentation/api/incubator/builder/internal/DefaultHttpClientInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
...mentation/api/incubator/semconv/http/HttpClientExperimentalHttpParamsRedactionExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
semantic conventions define the same redactions for |
I think it's ok to scope this PR to http client spans since that's the primary issue in Java at least (update the title, the config option is already scoped to http clients) |
I have created #13292 |
… other experimental options
…tion/api/semconv/http/HttpClientAttributesExtractor.java Co-authored-by: Lauri Tulmin <[email protected]>
f9a1d63
to
4911e83
Compare
edcdb3a
to
5164fe5
Compare
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Show resolved
Hide resolved
@trask Does it seem good for you? |
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
…tion/api/semconv/http/HttpClientAttributesExtractor.java
Co-authored-by: Steve Rao <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md