-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @WithSpan option to break from existing context #13112
Add @WithSpan option to break from existing context #13112
Conversation
Signed-off-by: xiepuhuan <[email protected]>
The smoke test of grpc failed. Because I modified the |
You got it wrong. The test is failing because after your changes the instrumentation does not work any more for old version of the |
@laurit Thank you for your reply. I want to use reflection to determine whether the |
...ntation-annotations/src/main/java/io/opentelemetry/instrumentation/annotations/WithSpan.java
Outdated
Show resolved
Hide resolved
...ntation-annotations/src/main/java/io/opentelemetry/instrumentation/annotations/WithSpan.java
Outdated
Show resolved
Hide resolved
…nstrumentation into add-option-withparent-to-annotation-withspan
…ion-withspan' into add-option-withparent-to-annotation-withspan
...opentelemetry/javaagent/instrumentation/instrumentationannotations/AnnotationSingletons.java
Outdated
Show resolved
Hide resolved
...trumentation/spring/autoconfigure/internal/instrumentation/annotations/JoinPointRequest.java
Outdated
Show resolved
Hide resolved
Adding docs for the params here: open-telemetry/opentelemetry.io#6543 |
Related to #1036