Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate 6: don't record NoResultException #12879

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Dec 11, 2024

Resolves #12863
Resolves #12125
Hibernate 4 instrumentation does not record this exception or mark the span as failed.

@laurit laurit requested a review from a team as a code owner December 11, 2024 14:29
Comment on lines +48 to +49
// not instrumenting getSingleResult as it calls list that is instrumented and
// we don't want to record the NoResultException that it throws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laurit laurit merged commit 9da29ca into open-telemetry:main Dec 12, 2024
56 checks passed
@laurit laurit deleted the hibernate6-no-result branch December 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants