-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for missing spring list properties #12819
Conversation
@@ -419,8 +419,8 @@ | |||
}, | |||
{ | |||
"name": "otel.instrumentation.logback-appender.experimental.capture-mdc-attributes", | |||
"type": "java.util.List<java.lang.String>", | |||
"description": "MDC attributes to capture. Use the wildcard character <code>*</code> to capture all attributes." | |||
"type": "java.lang.String", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanbisutti this property is used by
Line 19 in 5b21872
class LogbackAppenderInstaller { |
@CofigurationProperties
at that stage yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean.
From what I observe, @Value
does not seem to work in LogbackAppenderApplicationListener
.
org.springframework.boot.context.logging.LoggingApplicationListener
does not use @Value
.
@jeanbisutti please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help make the release note, could you please list the added properties in the description?
Are we sure that all the added properties are working? Perhaps it may be worth adding automatic tests.
@@ -419,8 +419,8 @@ | |||
}, | |||
{ | |||
"name": "otel.instrumentation.logback-appender.experimental.capture-mdc-attributes", | |||
"type": "java.util.List<java.lang.String>", | |||
"description": "MDC attributes to capture. Use the wildcard character <code>*</code> to capture all attributes." | |||
"type": "java.lang.String", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean.
From what I observe, @Value
does not seem to work in LogbackAppenderApplicationListener
.
org.springframework.boot.context.logging.LoggingApplicationListener
does not use @Value
.
...boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Show resolved
Hide resolved
17bf85b
to
03a6fd2
Compare
done |
...try/instrumentation/spring/autoconfigure/internal/properties/SpringConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
...try/instrumentation/spring/autoconfigure/internal/properties/SpringConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
@zeitlinger could you elaborate what this change is about. Did these list properties work at all previously or did the work in some different way? If the worked in some different way is this change backwards compatible? |
Old: prop: a,b New: prop: a,b OR prop: [a,b]
yes |
No description provided.