Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate byte buddy classes #12571

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Nov 5, 2024

Since 1.15.5 byte buddy includes classes compiled for java 5 at the root of the jar and the same classes compiled for java 8 under META-INF/versions/9. Removing these duplicate classes is suggested in https://github.com/raphw/byte-buddy/tree/master?tab=readme-ov-file#dependency-and-api-evolution

@laurit laurit requested a review from a team as a code owner November 5, 2024 12:07
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I had noticed the agent jar size increase due to this in the last release

@laurit laurit merged commit 78b3c6a into open-telemetry:main Nov 6, 2024
56 checks passed
@laurit laurit deleted the byte-buddy-duplicate branch November 6, 2024 05:44
akats7 pushed a commit to akats7/opentelemetry-java-instrumentation that referenced this pull request Nov 21, 2024
akats7 pushed a commit to akats7/opentelemetry-java-instrumentation that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants