compatible different command line style for find jar path #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compatible command like : java -jar -XX:MaxRAM=128m app.jar
…-style compatible different command line style for find jar path
trask
reviewed
Nov 5, 2024
yes. |
trask
approved these changes
Nov 5, 2024
...ary/src/test/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetectorTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <[email protected]>
laurit
reviewed
Nov 6, 2024
...ary/src/test/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetectorTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Nov 6, 2024
...ary/src/test/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetectorTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Nov 6, 2024
...rces/library/src/main/java/io/opentelemetry/instrumentation/resources/MainJarPathFinder.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Nov 6, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatible command like : java -jar -XX:MaxRAM=128m app.jar
The JAR file name does not always come immediately after the -jar command; there may be other JVM parameters in between the two.
by now, if we use the java -jar -XX:MaxRAM=128m app.jar command to start the applicaion. we can not get the real jar name.
we will get the warn log like below:
otel.javaagent 2024-10-29 09:24:19:600 +0000] [main] WARN io.opentelemetry.instrumentation.resources.ManifestResourceProvider - Error reading manifest java.nio.file.NoSuchFileException: -XX:MaxRAM=128mResolves #12545