Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logback mdc instrumentation to spring boot starter #12515

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add logback mdc instrumentation to spring boot starter #12515

merged 4 commits into from
Oct 29, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 25, 2024 •
edited
Loading

This is for feature parity with the agent.

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Oct 25, 2024
@laurit laurit marked this pull request as ready for review October 25, 2024 11:37
@laurit laurit requested a review from a team as a code owner October 25, 2024 11:37
@trask
Copy link
Member

trask commented Oct 25, 2024

cc @jeanbisutti @zeitlinger

@jeanbisutti jeanbisutti mentioned this pull request Oct 29, 2024
Closed
@trask trask merged commit 0521ac1 into open-telemetry:main Oct 29, 2024
55 of 56 checks passed
@AntonioLyubchev AntonioLyubchev mentioned this pull request Oct 31, 2024
Merged
@AntonioLyubchev
Copy link

@laurit, is there a way I can immediately use this with a Spring Boot Starter? Tried adding the dependency https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/logback/logback-mdc-1.0/library and the proposed logback config but I get Failed to instantiate type io.opentelemetry.instrumentation.logback.mdc.v1_0.OpenTelemetryAppender

@laurit laurit deleted the spring-starter-logback-mdc branch October 31, 2024 17:04
@laurit
Copy link
Contributor Author

laurit commented Oct 31, 2024

@laurit, is there a way I can immediately use this with a Spring Boot Starter? Tried adding the dependency https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/logback/logback-mdc-1.0/library and the proposed logback config but I get Failed to instantiate type io.opentelemetry.instrumentation.logback.mdc.v1_0.OpenTelemetryAppender

Sure you can, you just have to include the library and configure it manually. If you can not get it working create a new issue and include a minimal application that reproduces your issue along with any necessary instructions.

@jeanbisutti jeanbisutti mentioned this pull request Nov 19, 2024
Closed
akats7 pushed a commit to akats7/opentelemetry-java-instrumentation that referenced this pull request Nov 21, 2024
@laurit
Add logback mdc instrumentation to spring boot starter (open-telemetr…
50af708 
…y#12515)
akats7 pushed a commit to akats7/opentelemetry-java-instrumentation that referenced this pull request Nov 21, 2024
@laurit
Add logback mdc instrumentation to spring boot starter (open-telemetr…
b2607e8 
…y#12515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@zeitlinger zeitlinger Awaiting requested review from zeitlinger

Assignees
No one assigned
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurit @trask @AntonioLyubchev @jeanbisutti