Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure-core nested HTTP suppression, update libs #12489

Merged

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 21, 2024

Azure-core instrumentation is based on the native plugin and can be enabled/disabled using azure-core public APIs.
The instrumentation produces two types of spans: logical for API-level and HTTP (with some azure-specific context).

Azure-core HTTP spans suppress underlying HTTP spans generated by otel instrumentations (inside java-agent part)

Some users are not interested in the logical spans, but want to keep HTTP ones coming.
When azure-core instrumentation is disabled, it applies to all spans.


The problem is that suppression mechanism used in the agent part suppresses all HTTP spans done by azure-core regardless of whether the request was instrumented by azure-core or not.


This PR:

  • suppresses only when the corresponding request was instrumented by Azure core (based on the context flag)
  • updates azure packages to the latest version (there were some non-breaking API changes that might still lead to conflicts when old azure-core is used with a new tracing plugin)

See also: Azure/azure-sdk-for-java#41100

@github-actions github-actions bot requested a review from theletterf October 24, 2024 23:01
@lmolkova lmolkova changed the title [WIP] Fix azure-core nested HTTP suppression, update libs Fix azure-core nested HTTP suppression, update libs Oct 24, 2024
@lmolkova lmolkova force-pushed the azure-core-update-and-fix-suppression branch from d8a6655 to e247e56 Compare October 24, 2024 23:02
@lmolkova lmolkova marked this pull request as ready for review October 24, 2024 23:06
@lmolkova lmolkova requested a review from a team as a code owner October 24, 2024 23:06
@trask trask added this to the v2.10.0 milestone Oct 26, 2024
@trask
Copy link
Member

trask commented Oct 26, 2024

@lmolkova whenever you have time, take a look at the simplification I pushed to make sure I didn't miss anything, thanks!

@lmolkova
Copy link
Contributor Author

Thanks @trask ! This looks great.

A side-note - I'll need to add new azure-core version in the future, but it's indeed not essential now and can wait for months.

@trask trask merged commit d3f808e into open-telemetry:main Oct 26, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants