Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set Logback argument capture with a property in Spring Boot Starter #12442

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Ability to set Logback argument capture with a property in Spring Boot Starter #12442

merged 1 commit into from
Oct 16, 2024

Conversation

jeanbisutti
Copy link
Member

@jeanbisutti jeanbisutti commented Oct 15, 2024 •
edited
Loading

Related to #12431

It was not possible the configure the argument capture of the Logback starter instrumentation from a property.

@jeanbisutti jeanbisutti requested a review from a team as a code owner October 15, 2024 09:35
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Oct 15, 2024
@laurit
Copy link
Contributor

laurit commented Oct 15, 2024

@jeanbisutti any reason why you sed Related to instead of Resolves (will auto close the issue when PR is merged) in the issue comment?

@jeanbisutti
Copy link
Member Author

@laurit #12445 fixes #12431 (with #12445 the OpenTelemetry starter will have the argument capture disabled by default)

@trask trask changed the title Ability to set Logback argument capture with a property Ability to set Logback argument capture with a property in Spring Boot Starter Oct 16, 2024
@trask trask merged commit d8eddfc into open-telemetry:main Oct 16, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanbisutti @laurit @trask