try to handle issues in Pekko tracing when the scheduler is used #12359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Sep 30, 2024
...pentelemetry/javaagent/instrumentation/pekkoactor/v1_0/PekkoScheduleOnceInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 30, 2024
...java/io/opentelemetry/javaagent/instrumentation/pekkoactor/v1_0/ExecutionContextWrapper.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 30, 2024
...java/io/opentelemetry/javaagent/instrumentation/pekkoactor/v1_0/ExecutionContextWrapper.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 30, 2024
| @@ -32,4 +39,23 @@ class PekkoHttpServerInstrumentationTestAsync | |||
| super.configure(options) | |||
| options.setTestHttpPipelining(false) | |||
| } | |||
|
|
|||
| @Test | |||
| def successfulPostRequestWithParent(): Unit = { | |||
There was a problem hiding this comment.
Test name indicates that you are testing something completely different than what your true goal is. Test should be name appropriately. Parts that you don't need should be removed, do you really need the tracePARENT stuff? Why not send a simple get? I'd guess that for what you want to test you don't need to make a http request at all, perhaps you could skip that altogether?
There was a problem hiding this comment.
I'll look into rewriting this test
There was a problem hiding this comment.
@laurit thanks for looking at the PR so quickly. I wrote a new test that does not use HTTP.
laurit
reviewed
Oct 1, 2024
...st/scala/io/opentelemetry/javaagent/instrumentation/pekkoactor/v1_0/PekkoSchedulerTest.scala
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 1, 2024
...st/scala/io/opentelemetry/javaagent/instrumentation/pekkoactor/v1_0/PekkoSchedulerTest.scala
Outdated
Show resolved
Hide resolved
class names add tests Update PekkoScheduleInstrumentation.java fix matcher ExecutionContextWrapper Update PekkoHttpTestAsyncWebServer.scala extend test remove ExecutionContextWrapper remove PekkoScheduleOnceInstrumentation Create PekkoSchedulerTest.scala remove new http test spotless Update PekkoSchedulerTest.scala
pjfanning
force-pushed
the
pekko-schedule
branch
from
779e207 to
f8f82f9
Compare
laurit
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #11755
The code is based on @wsargent 's workaround in https://github.com/wsargent/opentelemetry-with-scala-futures and includes the test submitted by @Dogacel