Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OpenTelemetryHandlerMappingFilter handle exceptions from Servlet… #12221

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Make OpenTelemetryHandlerMappingFilter handle exceptions from Servlet… #12221

merged 1 commit into from
Sep 12, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Sep 11, 2024

…RequestPathUtils.parseAndCache
Hopefully resolves #12214
I wasn't able to reproduce the issue.

@laurit laurit requested a review from a team September 11, 2024 12:31
@laurit laurit added this to the v2.8.0 milestone Sep 11, 2024
XuyuFu
XuyuFu approved these changes Sep 11, 2024
View reviewed changes
Copy link

@XuyuFu XuyuFu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issue. It's great to have the exception logged at FINE level!

@laurit laurit merged commit 39668b5 into open-telemetry:main Sep 12, 2024
56 checks passed
@laurit laurit deleted the handler-mapping-filter-exception branch September 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@XuyuFu XuyuFu XuyuFu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

OpenTelemetryHandlerMappingFilter throws exceptions for invalid request path
3 participants
@laurit @trask @XuyuFu