This repository was archived by the owner on Apr 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
+196
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
render key in template literal remove empty array type
e8f6a8a
to
59cdfaa
Compare
…to bugfix/scroll-lag
Codecov Report
@@ Coverage Diff @@
## master #2446 +/- ##
=========================================
+ Coverage 42.62% 42.72% +0.1%
=========================================
Files 332 332
Lines 13212 13209 -3
Branches 1736 1736
=========================================
+ Hits 5632 5644 +12
+ Misses 7302 7287 -15
Partials 278 278
Continue to review full report at Codecov.
|
fix rendering of incomplete indentations
CrossR
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, and from a quick test of jumping around a file, I wasn't able to get any UI issues on scroll like before.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2344 buffer layers suffer from laggy rendering on scroll, on some investigation it seems the
auditTime
we use in theshouldMeasure$
observable means that the information is not being updated in real time so scrolling quickly through a buffer causes indentlines or color highlights to appear in a janky fashion i.e. they are out of place.Not sure what it was used for but I think because the information is required by ui pieces which need v. up to date data re window details we should allow things to be updated as often possible. This change greatly improves the rendering.
There are a couple of things which still cause the ui to be a bit janky:
?
or/
can move the viewport towards the match(es) in this case window details passed to context don't seem to updateOther additions:
I also tweaked the indent lines to use a
bannedFiletypes
buffer as opposed to a whitelist aka as discussed with @CrossR it is now on for all filetypes except those which are blacklisted. @CrossR examples of where you would want a black list I think would be most vim plugin buffers likepeekabo
orstartify
ornerdtree
etc. in these cases the indentlines rarely render desirably and are arguably not required.I render the first indent line which is the same behaviour as in
vscode
however i've added an option.experimental.indentLines.skipFirst
which allows a user to avoid this behaviour if they would prefer