[R] Partial i18n refactor & notification visual effect improvements #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oau-main-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeiyanYunyi
approved these changes
Jun 25, 2023
src/App.vue
Outdated
Comment on lines
44
to
54
| let lang = getLang(); | ||
| if (lang === 'zh_hant') | ||
| { | ||
| ((document.querySelector('div#nav') as Element).firstElementChild.children.item(0) as Element).textContent = "首頁" as string | ||
| ((document.querySelector('div#nav') as Element).firstElementChild.children.item(1) as Element).textContent = "聯繫" as string | ||
| } | ||
| if (lang === 'en') | ||
| { | ||
| ((document.querySelector('div#nav') as Element).firstElementChild.children.item(0) as Element).textContent = "Home" as string | ||
| ((document.querySelector('div#nav') as Element).firstElementChild.children.item(1) as Element).textContent = "Contact" as string | ||
| } |
There was a problem hiding this comment.
在 Vue 里面用 querySelector 手动设置内容不太好... 改了一下改成用一个变量定义多语言文字了
|
改了一下切换语言按钮
|
|
本地化了一些翻译细节，整体还不错。 （还没改完，好累呜呜 |
|
把原文的 （以及为什么是个了解更多页面（气鼓鼓 |
LS-KR
force-pushed
the
main
branch
7 times, most recently
from
9b3b3e4 to
b4645be
Compare
hykilpikonna
added a commit
to one-among-us/tg-blog
that referenced
this pull request
Jul 3, 2023
LS-KR
changed the title
Aquaticat
reviewed
Jul 9, 2023
Aquaticat
reviewed
Jul 9, 2023
Aquaticat
reviewed
Jul 9, 2023
|
这回是真改过来了qwq（ |
|
你们觉得咋样？能上线就先合了，剩下的慢慢改。 |
|
我觉得可以。 |
|
咱想不出需要添加/修改的新点子了qwq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
还是手译的（塑料英语）