Distinguish directors and guests in BoD attendance lists #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO it makes the code easier to understand in the long run
This commit makes the minutes script split the "Attendance" block in BoD minutes. The note-taker still writes a single Attendance block, like before; however, after they exit the text editor, the Attendance block is replaced with two blocks, an attendance block for directors and an attendance block for guests. Guests are further marked with an asterisk if they choose to join BoD at that meeting. Major changes have been made to the BoD module. Most notably, the membership file is eliminated. Membership is now dynamically determined from the attendance lists in the minutes. One drawback is that you cannot run `minutes` to take BoD minutes twice in the same day without re-combining the attendance lists, or else it crashes. This can be remedied in the future.
|
Comments? If not I'm going to merge these. |
|
Perhaps we should check to make sure everyone who's "on bod" has an OCF account to capture occasions when the minutes-taker misspells usernames, and prompts them to correct it or mark them as a guest. Transcription errors are likely and may lead to people getting kicked off bod because of faulty minutes-taking. |
|
Yeah, that's issue #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the minutes script split the "Attendance"
block in BoD minutes. The note-taker still writes a single
Attendance block, like before; however, after they exit the
text editor, the Attendance block is replaced with two blocks,
an attendance block for directors and an attendance block for
guests. Guests are further marked with an asterisk if they
choose to join BoD at that meeting.
Major changes have been made to the BoD module. Most notably,
the membership file is eliminated. Membership is now dynamically
determined from the attendance lists in the minutes.
One drawback is that you cannot run
minutesto take BoD minutestwice in the same day without re-combining the attendance lists,
or else it crashes. This can be remedied in the future.