Reveal: Fix Reveal plugin always revealing PCs when the plugin is enabled, regardless of usage. #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled, regardless of usage.
|
I'll assume this fixes whatever is broken since I don't use it. |
Daztek
reviewed
Aug 26, 2023
Daztek
reviewed
Aug 26, 2023
Comment on lines
+61
to
+62
| if (detectionVector && *detectionVector) | ||
| *bSeen = *detectionVector; |
There was a problem hiding this comment.
needs a
else
*bSeen = false;
the variables that bSeen/bHeard are pointing to aren't initialized, so they should always be set to something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the label on the tin says, this fixes PCs always being revealed to other PCs when the plugin is enabled regardless of plugin usage, as mentioned by someone on discord a while ago which I ran into today when enabling and attempting to use the plugin: https://discord.com/channels/382306806866771978/387223972808359936/1121979712818917436