Creature: DoItemCastSpell () allow setting casting item and impact script #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daztek
reviewed
Apr 14, 2023
Comment on lines
+2853
to
+2854
| auto oidItem = args.extract<ObjectID>(); | ||
| auto impactScript = args.extract<std::string>(); |
There was a problem hiding this comment.
Like your other PR, this is also a breaking ABI change, would be nice to mention it in the changelog.
There was a problem hiding this comment.
Ah, my bad! I didn't realize that would be ABI breaking. Can I blame inexperience? I'll note it in the changelog, same with the other PR.
summonFox
deleted the
Creature--more-param-overrides-for-DoItemCastSpell
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows oItem retrieved by GetSpellCastItem() to be set in DoItemCastSpell(), as well as overriding the impact script (or even removing the impact script if set to "****").
When combined with NWNX_ON_BROADCAST_SAFE_PROJECTILE_BEFORE it allows us to effectively create a ActionCastCustomFakeSpell() function that casts a ActionCastFakeSpell* or ActionCastSpell*, which we then replace with DoItemCastSpell() during the broadcast event to use a custom projectile or impact script instead.