Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: md-code specs/attribs #405

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Valexr
Copy link
Contributor

@Valexr Valexr commented Nov 16, 2024

Simple fix #401

export function parseTag(input) {
  const { str, getValue } = valueGetter(input)
  const strings = str.split(/\s+/)
  const specs = strings.filter((s, i) => !i || s.match(/^[#|.]/)).join('')
  const attribs = strings.filter(s => !specs.includes(s))
  const self = { ...parseSpecs(specs), data: {} }
  ...

Nue has a VERY GOOD IDEAs 👍🏻, but I think it's needed semantic specs & convention for more neat, structured & easy maintained codebase 🤔

@nobkd nobkd requested a review from tipiirai November 30, 2024 16:41
@tipiirai tipiirai merged commit e1a75f3 into nuejs:master Dec 9, 2024
4 checks passed
@tipiirai
Copy link
Contributor

tipiirai commented Dec 9, 2024

Thanks!

The challenge here is that "neat" or "structured" are subjective. Hope we find a good/satisfying balance as we move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nue-glow - syntax highlight lang + class
2 participants